Repository navigation
Enforce the cross-kit check in phasing and rebuilding - #7
Merged
Merged
Conversation
S7 was built but nothing called it. Phasing with a parent and rebuilding from children both rest on stated relationships, so they now measure the raw kits first and stop with SanityStop unless the DNA fits: parent-child for the parent, full siblings for the children. The Kits screen lists the relationships each measured pair fits. Tested on simulated kits: a stranger or grandparent as parent, a wrong other parent and half siblings all stop. The Kits screen text hasn't been seen in the built app. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes K655.
phaseWithParentandrebuildFromDescendantsnow callrequireRawRelationshipbefore any work: parent-child cM for the tested parent, full-sibling cM between children. The Kits screen lists what each measured pair fits (fittingRelationships,RELATIONSHIP_WORDS).Tested: 270 tests, typecheck, leak check. New cases: stranger and grandparent as parent, wrong other parent, half siblings. Not seen in the built app.
🤖 Generated with Claude Code